[JENKINS-50597] Network behavior tuning IV #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al and remote loggers. Evidently StreamTaskListener does not guarantee line-level interleaving.
kuisathaverat
approved these changes
Jun 3, 2018
…ms. So far seems adequate for our purposes.
Member
Author
|
Hmm, errors look random, and I cannot reproduce locally, though I have seen something locally when not using a clean build. This suggests that it is specific to Guice 3; google/guice#1119 is unclear. See JENKINS-50520. |
kuisathaverat
approved these changes
Jun 5, 2018
…a-retrying library.
carlossg
reviewed
Jun 6, 2018
| new FilePath(f).untarFrom(is, FilePath.TarCompression.GZIP); | ||
| // Note that this API currently offers no count of files in the tarball we could report. | ||
| } | ||
| client.connect("download", "download " + url.toString().replaceFirst("[?].+$", "?…") + " into " + f, c -> c.execute(new HttpGet(url.toString())), response -> { |
Contributor
There was a problem hiding this comment.
… vs ... ?
should replace passwords in http://user:password@...
wouldn't be easier to parse into Url and pick the sections needed rather than regex?
Member
Author
There was a problem hiding this comment.
Oops, forgot to use sanitize here!
| Date lastModified = sm.getLastModified(); | ||
| saved.put(sm.getName().substring(prefixLength), new CachedMetadata(length, lastModified != null ? lastModified.getTime() : 0)); | ||
| try { | ||
| Iterator<StorageMetadata> it = listStorageMetadata(true); |
Contributor
There was a problem hiding this comment.
why Iterator instead of Stream? curious
Member
Author
There was a problem hiding this comment.
I wanted direct handling over exceptions, which is awkward using the Stream API.
carlossg
approved these changes
Jun 7, 2018
Member
Author
|
The upstream is still unmerged and needs a review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-50597 continuing from #41.
archiveArtifacts,stash)unstashunarchive/copyartifact*zip*URLs,…/artifact/index browsing)Using jenkinsci/apache-httpcomponents-client-4-api-plugin#9:
unarchivecopyartifact